Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): don't publish a new docker image on non-code changes #31

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

tankerkiller125
Copy link
Contributor

@tankerkiller125 tankerkiller125 commented Jun 20, 2024

Stops the docker build processes from running if there are no real code changes (docs, readme, etc.)

Summary by CodeRabbit

  • Chores
    • Updated GitHub workflows to exclude documentation and contribution files from triggering workflow runs.

Copy link
Contributor

coderabbitai bot commented Jun 20, 2024

Walkthrough

Walkthrough

The updates to the GitHub workflows involve configuring paths-ignore to prevent changes to documentation files and certain Markdown files from triggering unnecessary workflow runs. This optimization targets the workflow files associated with Docker publishing and pull requests to streamline the CI/CD process and reduce redundant processing.

Changes

File Path Change Summary
.github/workflows/docker-publish-rootless.yaml Added paths-ignore for docs/**, README.md, CONTRIBUTING.md, and CODE_OF_CONDUCT.md in push and pull_request events.
.github/workflows/docker-publish.yaml Added paths-ignore for docs/**, README.md, CONTRIBUTING.md, and CODE_OF_CONDUCT.md in push and pull_request events.
.github/workflows/pull-requests.yaml Added paths-ignore configurations for specific files to exclude them from triggering workflow runs on push or pull requests to the main branch.

Poem

In the code's grand dance, we find,
Paths to ignore, a workflow's mind,
Docs and README, left benign,
Efficiency rises, processes aligned.
🎶✨🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tankerkiller125
Copy link
Contributor Author

@coderabbitai review

Copy link
Contributor

coderabbitai bot commented Jun 20, 2024

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 22c76c5 and 1227e46.

Files selected for processing (3)
  • .github/workflows/docker-publish-rootless.yaml (1 hunks)
  • .github/workflows/docker-publish.yaml (1 hunks)
  • .github/workflows/pull-requests.yaml (1 hunks)
Files skipped from review due to trivial changes (3)
  • .github/workflows/docker-publish-rootless.yaml
  • .github/workflows/docker-publish.yaml
  • .github/workflows/pull-requests.yaml

@tankerkiller125 tankerkiller125 merged commit add57a8 into main Jun 20, 2024
5 checks passed
@tankerkiller125 tankerkiller125 deleted the mk/binaries-publish branch June 20, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant